Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable hunting when no more balls #5871

Merged
merged 2 commits into from
Jan 13, 2017
Merged

Conversation

davidakachaos
Copy link
Contributor

Short Description:

When the bot isn't catching Pokemon because a lack of balls, don't hunt for Pokemon.

Fixes/Resolves/Closes (please use correct syntax):

  • Nothing, small enhancement

@mention-bot
Copy link

@davidakachaos, thanks for your PR! By analyzing the history of the files in this pull request, we identified @anakin5 to be a potential reviewer.

@MerlionRock
Copy link
Contributor

I thought there's already such function?

in config, add

{ "type": "CatchLimiter", "config": { "enabled": true, "min_balls": 30, "duration": 15 } },

@davidakachaos
Copy link
Contributor Author

Yes this function works great 😄 But the Pokemon Hunter will still move toward a Pokemon of interest and starts searching for it, while we won't catch it (because the CatchLimiter is active)

This PR makes the Pokemon Hunter stop searching for or moving toward a Pokemon when we don't catch Pokemon. Thus the bot will keep moving toward Pokestops instead of needlessly searching for Pokemon.

I hope this makes this PR a bit clearer

@Jcolomar
Copy link
Contributor

Asap devs log they merge all changes

@solderzzc
Copy link
Contributor

solderzzc commented Jan 13, 2017

👍

Approved with PullApprove

@solderzzc solderzzc merged commit 00d200d into PokemonGoF:dev Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants